Skip to content

Remove dependency from "bevy_platform/web" to "bevy_platform/std"#22184

Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom
kpreid:web-std
Jan 28, 2026
Merged

Remove dependency from "bevy_platform/web" to "bevy_platform/std"#22184
alice-i-cecile merged 1 commit intobevyengine:mainfrom
kpreid:web-std

Conversation

@kpreid
Copy link
Contributor

@kpreid kpreid commented Dec 18, 2025

Objective

Fixes #22168.

Solution

Remove dependency from "bevy_platform/web" to "bevy_platform/std", partially reverting #20369.

This PR was made per @alice-i-cecile 's suggestion #22168 (comment). I am not familiar enough with Bevy internal dependencies to know if this is a wise change.

Testing

  • Manually tested that the no_std build described in the issue succeeds.
  • Added a regression test in CI.
  • Did not test whether this has any negative effects on actual web builds.

This allows the “web” feature to be enabled without breaking the
build on non-web `no_std` targets. See
<bevyengine#22168>.
@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior O-Web Specific to web (WASM) builds D-Modest A "normal" level of difficulty; suitable for simple features or challenging fixes S-Needs-Review Needs reviewer attention (from anyone!) to move forward S-Needs-Testing Testing must be done before this is safe to merge P-Regression Functionality that used to work but no longer does. Add a test for this! A-Utils Utility functions and types labels Dec 18, 2025
Copy link
Contributor

@HugoPeters1024 HugoPeters1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @NthTensor do you remember if there was a special reason for introducing this?

Copy link
Contributor

@NthTensor NthTensor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think this was just an oversight between me and bushrat.

@NthTensor NthTensor added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 28, 2026
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jan 28, 2026
@alice-i-cecile alice-i-cecile removed the S-Needs-Testing Testing must be done before this is safe to merge label Jan 28, 2026
Merged via the queue into bevyengine:main with commit cf32081 Jan 28, 2026
57 checks passed
@kpreid kpreid deleted the web-std branch January 29, 2026 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Utils Utility functions and types C-Bug An unexpected or incorrect behavior D-Modest A "normal" level of difficulty; suitable for simple features or challenging fixes O-Web Specific to web (WASM) builds P-Regression Functionality that used to work but no longer does. Add a test for this! S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

no_std regression: is features = ["web"] supposed to affect non-web targets?

4 participants